Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add timeout to codecov #5770

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[CI] Add timeout to codecov #5770

merged 2 commits into from
Apr 25, 2024

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Apr 24, 2024 •
edited
Loading

Recently, we've noticed some codecov jobs taking hours to complete. This PR upgrades the action to the latest version and adds a timeout. If the step fails due to a timeout, the job will continue without error

@sjonpaulbrown
Copy link
Collaborator

The move to v4 won't work without a token variable injected into the action. The move to v4 will break without the additional change. The failure can be seen here on the CI job.

https://github.com/codecov/codecov-action?tab=readme-ov-file#v4-release

For the time being, we can either keep it at v3, or we will likely want to add support for the token.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.66%. Comparing base (8afb152) to head (6223be9).
Report is 1148 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5770      +/-   ##
==========================================
- Coverage   56.00%   55.66%   -0.35%     
==========================================
  Files        1024     1094      +70     
  Lines       99327    85308   -14019     
==========================================
- Hits        55632    47487    -8145     
+ Misses      39455    33255    -6200     
- Partials     4240     4566     +326
Flag Coverage Δ
unittests 55.66% <ø> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue
Copy link
Contributor Author

reports seem to be working now with the updated token:
https://github.com/onflow/flow-go/actions/runs/8823148130/job/24222983697?pr=5770

turbolent
turbolent approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🙏

@peterargue peterargue enabled auto-merge April 24, 2024 22:38
@peterargue peterargue added this pull request to the merge queue Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 24, 2024
@peterargue peterargue added this pull request to the merge queue Apr 24, 2024
Merged via the queue into master with commit 48500c0 Apr 25, 2024
55 checks passed
@peterargue peterargue deleted the petera/add-codecov-timeout branch April 25, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@sjonpaulbrown sjonpaulbrown sjonpaulbrown approved these changes

@turbolent turbolent turbolent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterargue @sjonpaulbrown @codecov-commenter @turbolent @janezpodhostnik